Re: [PATCH] : Inversion for options

On Wed, Dec 05, 2007 at 11:06:09PM +0100, Krzysztof Oledzki wrote:
> So, something like "no option contstats" will satisfy you? OK, this can be
> done. ;)

Yes, that would be cool.

> >At first glance, that makes sense. But since it's used only for forceclose,
> >I think it should be processed in a simpler way: let's only set one bit per
> >option in the cfg_opts[], and check for PR_O_FORCE_CLO too everywhere we
> >check
> >for PR_O_HTTP_CLOSE (only 4 places). This would make a lot more sense given
> >the fact that options are just booleans, and it would definitely remove all
> >those complex calculations.
>
> But we still need this complex calculations for last_checks. If you wish I
> can remove ival and fix PR_O_FORCE_CLO but I think we will need such
> functionality some day anyway...

Probably, but at least you can remove the added column in the table for now, as it will only contain zeroes :-)

> >>I also decided to depreciate "redisp" and "redispatch"
> >>keywords as it is IMHO better to use "option redispatch" which can be
> >>inverted.
> >
> >Agreed. I think we will need some general purpose function to deprecate
> >such
> >keywords and provide hints for their replacement.
>
> Right. Are there more keywords we need to mark deprecated?

None that come to my mind right now, but I think that later, all the req*, rsp* and {cli|srv|con}timeout will be replaced too.

> >I'm releasing 1.3.14 today, but will probably merge your (updated) work in
> >1.3.14.1 as it's non-intrusive and almost riskless.
>
> OK. Thank you.

You're welcome :-)

Cheers,
Willy Received on 2007/12/05 23:13