Re: [PATCH] Fix compile errors on Debian systems

Hi Arnaud,

On Tue, Jan 01, 2008 at 10:49:40PM +0100, Arnaud Cornet wrote:
> Hi Willy,
>
> > Also, I'd be very interested in knowing what CFLAGS used by Debian manage
> > to break the build process. If there is a weakness anywhere, we should
> > address it and not only the symptoms.
>
> I have no idea of the work of Jean-Baptiste Quenot, but my guess is that
> this problem has nothing to do with building haproxy on debian but
> rather to build the debian *package* on debian (as this is a problem I
> encountered and fixed in debian haproxy package).
>
> The problem is that CFLAGS variables a classically overriden in debian
> packages using commands such as
>
> make CFLAGS="-O2 -g"

Hmmm that's getting interesting :-)

> When using this, the following makefile line is overridden:
>
> CFLAGS = -Wall $(COPTS) $(DEBUG)
>
> Hence, the COPTS variable is ignored. The COPTS variable has the
> -Iinclude flags, trying to builds without this obviously breaks.
>
> Anyway, that's not a problem at all. I guess it would be slightly easier
> if you had CFLAGS only contain -Wall -Ox and -g flags and use another
> variable that has the other parameters, because your makefile would be
> more "classical".

Yes I agree. I recently had the intention to slightly lift up the makefile in order to separate several sets of options :

• compiler optimization (-O, -g, -fomit-frame-pointer, ...)
• architecture-dependant flags (-march=, -mcpu=, -mtune=, ...)
• build options (-DCONFIG_CTTPROXY, ...)
• includes and libs (-Ixxx, -Lxxx)
• the internal "glue" between all those flags (-DBUILD_OPTS="$OPTS", ....)

I decided not to do it because of the good old principle "if it's not broken, don't touch it". But if now we're certain it's already broken somewhere, here is a good opportunity to make a change.

Oh and by the way, to those who might wonder if it's why not switching over to autoconf, I can already reply that as an end user, I *hate* having to debug that complicated crap, and I don't want to impose it to any of my users ;-)

Cheers,
Willy Received on 2008/01/01 23:23