Re: maybe dump question

On Wed, 30 Jan 2008, Aleksandar Lazic wrote:

> Hi,
>
> sometimes I make a diff from previous_version current_version, for my
> curiosity ;-)
>
>
> I have done this with haproxy-1.3.14.1 + haproxy-1.3.14.2
>
> diff -ru haproxy-1.3.14.1 haproxy-1.3.14.2|less
>
> and asked me why you have not combine this statement into a block?
>
> I think mybe for performance issue or some other reason?!
>
> ---- in haproxy-1.3.14.2/src/backend.c
>
> srv_count_retry_down()
> .
> .
> if (t->srv)
> t->srv->cum_sess++;
> if (t->srv)
> t->srv->failed_conns++;
>
> srv_retryable_connect()
> .
> .
> case SN_ERR_INTERNAL:
>
> if (t->srv)
> t->srv->cum_sess++;
> if (t->srv)
> t->srv->failed_conns++;
> ---

Probably to help solving a conflict with 25b501a6b12d8f4ca8cabe946b1286aa4020755c

(...)

-       if (t->srv)
+       if (t->srv) {
                 t->srv->cum_sess++;
-       if (t->srv)
                 t->srv->failed_conns++;
+               t->srv->redispatches++;
+       }

Just guess... ;)

Best regards,

                                 Krzysztof Olêdzki Received on 2008/01/30 22:17