Re: [PATCH] Don't increment server connections too much + fix retries

On Mon, Feb 04, 2008 at 09:37:50PM +0100, Willy Tarreau wrote:
> On Mon, Feb 04, 2008 at 02:17:01AM +0100, Krzysztof Oledzki wrote:
> > >From 9af493edbe56489524f57c22d58aca0584931c8a Mon Sep 17 00:00:00 2001
> > From: Krzysztof Piotr Oledzki <ole#ans.pl>
> > Date: Mon, 4 Feb 2008 02:10:09 +0100
> > Subject: [BUG] Don't increment server connections too much + fix retries
> >
> > Commit 98937b875798e10fac671d109355cde29d2a411a while fixing
> > one bug introduced another one. With "retries 4" and
> > "option redispatch" haproxy tries to connect 4 times to
> > one server server and 1 time to a second one. However
> > logs showed 5 connections to the first server (the
> > last one was counted twice) and 2 to the second.
> >
> > This patch also fixes srv->retries and be->retries increments.
> >
> > Now I get: 3 retries and 1 error in a first server (4 cum_sess)
> > and 1 error in a second server (1 cum_sess) with:
> > retries 4
> > option redispatch
> >
> > and: 4 retries and 1 error (5 cum_sess) with:
> > retries 4
> >
> > So, the number of connections effectively served by a server is:
> > srv->cum_sess - srv->failed_conns - srv->retries
>
> Fine, I'm applying this fix too. Good catch!

Finally, I'll wait for our discussions to converge before applying this one, because I suspect that we'll touch the same area again :-)

Cheers,
Willy Received on 2008/02/04 22:08