Re: [PATCH] proto_uxst rework -> SNMP support

On Wed, 27 Feb 2008, Willy Tarreau wrote:

> Hi Krzysztof,

Hi,

> Cool stuff. I'll *try* to process all your pending mails today.
Thanks.

> Concerning the 16kB limit on unix, it's certainly a bug, I will
> have to check. For the show stats, that's fine. I would initially
> have liked something with the names instead of numbers, but this
> is just the stats socket, designed exactly for this use, and not
> a CLI (there's a reason why it was called 'stats'), so in the end,
> numbers are the right method :-)

OK.

> Concerning the SNMP support, that looks fine. At Exosec, we have
> developped a net-snmp plugin to check the stats (which we use in
> our appliance), and decided to set it free as a contrib. It's just
> a matter of time to package it and release it as a distinct package.
>
> Since yours is probably simpler and smaller, there's no problem
> merging it into haproxy. You should probably create a "contrib"
> directory with another sub-directory inside for your program. We
> will then progressively move all other contribs there and leave
> only examples in the examples directory.

OK. I'll send a new version of this patch with the perl code moved to the contrib/netsnmp-perl directory. I'll also implement snmpwalk and change the order of parameters in oids as my colleagues suggested me that it should be grouped in a different way, so oids can be easily imported in Cacti.

Best regards,

                                 Krzysztof Olêdzki Received on 2008/02/27 18:07