Re: [PATCH] [MINOR] acl: don't report valid acls as potential mistakes

On Mon, Oct 05, 2009 at 12:43:01AM +0200, Krzysztof Piotr Oledzki wrote:
> >From c9ae0019236257ca57b062dd4cca0732cf98600c Mon Sep 17 00:00:00 2001
> From: Krzysztof Piotr Oledzki <ole#ans.pl>
> Date: Mon, 5 Oct 2009 00:23:35 +0200
> Subject: [MINOR] acl: don't report valid acls as potential mistakes
>
> Commit 404e8ab4615d564a74f92a0d3822b0292dd6224f introduced
> smart checking for stupid acl typos. However, now haproxy shows
> the warning even for valid acls, like this one:
> acl Cookie-X-NoAccel hdr_reg(cookie) (^|\ |;)X-NoAccel=1(;|$)

Yes you're really right, I didn't think about that valid case. Otherwise you can just put a backslash in front of the first opening parenthesis, but its troubling to put backspaces in regex rules, so your fix is the correct one.

Applied, thanks Krzysztof
Willy Received on 2009/10/08 07:02