Re: [PATCH] Fix compile errors on Debian systems

From: Willy Tarreau <w#1wt.eu>
Date: Wed, 2 Jan 2008 20:51:07 +0100


Hi Arnaud,

[I'm replying quickly, I must leave in 5 mins]

On Wed, Jan 02, 2008 at 07:17:51PM +0100, Arnaud Cornet wrote:
> > So if you know how I could make the dependencies optional, I agree to
> > add this feature, but if there is no easy way for this, I'd rather
> > leave it to the developer to know when to clean and when not to clean.
> > I certainly can replace "make" by "make haproxy" to do a partial rebuild,
> > but I do not want to have to hack deps files for this.
>
> I just made the makefile look more like mine for fun. I don't really
> mind.

OK. If you see a way it can be easily used only conditionnaly, feel free to propose it, I'd happily merge it.

> > By "older", you mean which version ? I'm asking this because eventhough
> > it's quite common to find GNU make >= 3.78.1 on Linux, when you work on
> > other platforms, versions 3.75..3.77 are quite common too.
>
> I know historical UNIX and BSD make do not deal with that. I am not sure
> if old GNU make lack that feature, but I doubt they do.

To be honnest, I really don't know. I already had to upgrade my gnu make several times because some packages would not build in the past.

BTW, I have reworked the makefile a lot today. It's really cleaner and more compatible with your common uses. I attach the patch. Your build scripts will be happy with the cflags. I even tried it on freebsd with gnu make and it worked there too!

I'm attaching the patch if you want to take a look at it (I've pushed it into git anyway).

Cheers,
Willy

Received on 2008/01/02 20:51

This archive was generated by hypermail 2.2.0 : 2008/01/02 21:00 CET